Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Max to raw_ops #5348

Merged
merged 5 commits into from
Oct 8, 2022
Merged

Added Max to raw_ops #5348

merged 5 commits into from
Oct 8, 2022

Conversation

KareemMAX
Copy link
Contributor

Close #5345

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Oct 6, 2022
iamjameskeane
iamjameskeane approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@iamjameskeane iamjameskeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will merge once conflicts are resolved!

@KareemMAX KareemMAX mentioned this pull request Oct 8, 2022
Merged
@KareemMAX
Copy link
Contributor Author

@jkeane508 Thanks for you review ❤
Merge conflicts are resolved now, other PRs I have (#5351, #5401) may result a conflict if merged first, just mention me if this happened and I'll resolve it ASAP.

@KareemMAX KareemMAX mentioned this pull request Oct 8, 2022
Merged
@iamjameskeane
Copy link
Contributor

@jkeane508 Thanks for you review ❤
Merge conflicts are resolved now, other PRs I have (#5351, #5401) may result a conflict if merged first, just mention me if this happened and I'll resolve it ASAP.

Yea there's merge issues now that I merged your other PR, if you get time please resolve here too 😅

@KareemMAX
Copy link
Contributor Author

@jkeane508 I resolved the issues, feel free to merge now

@iamjameskeane iamjameskeane merged commit 8263e83 into ivy-llc:master Oct 8, 2022
@KareemMAX KareemMAX deleted the max branch March 22, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamjameskeane iamjameskeane iamjameskeane approved these changes

Assignees

@iamjameskeane iamjameskeane

Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Max
3 participants
@KareemMAX @iamjameskeane @ivy-leaves