Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Diag to raw_ops #5471

Merged
merged 8 commits into from
Oct 18, 2022
Merged

Added Diag to raw_ops #5471

merged 8 commits into from
Oct 18, 2022

Conversation

KareemMAX
Copy link
Contributor

Close #5470

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Oct 8, 2022
Copy link
Contributor

@simonetgordon simonetgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@simonetgordon
Copy link
Contributor

Hi there, your test is passing, so this is ready to be merged. However, you need to resolve some conflicts before I can do that.

Thanks for your contribution!

@KareemMAX
Copy link
Contributor Author

@simonetgordon The PR now should be conflict free, thanks for your review ❤

Copy link
Contributor

@simonetgordon simonetgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needed to resolve merge conflict again (this file is busy!). Thanks!

@KareemMAX
Copy link
Contributor Author

@simonetgordon resolved conflicts again

@simonetgordon simonetgordon merged commit cc3aaf4 into ivy-llc:master Oct 18, 2022
@KareemMAX KareemMAX deleted the diag branch March 22, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diag
3 participants