-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Diag to raw_ops #5471
Added Diag to raw_ops #5471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Hi there, your test is passing, so this is ready to be merged. However, you need to resolve some conflicts before I can do that. Thanks for your contribution! |
@simonetgordon The PR now should be conflict free, thanks for your review ❤ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needed to resolve merge conflict again (this file is busy!). Thanks!
@simonetgordon resolved conflicts again |
Close #5470