Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arrcos, arrcosh, arcsin, arcsinh to jax.numpy frontend namespace functions #5675

Merged
merged 7 commits into from
Oct 16, 2022
Merged

Conversation

Torus403
Copy link
Contributor

No description provided.

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Oct 13, 2022
@modanesh
Copy link
Contributor

Thanks for your contribution. Could you link the issue this PR is trying to solve?

@Torus403
Copy link
Contributor Author

Torus403 commented Oct 15, 2022

Thanks for your contribution. Could you link the issue this PR is trying to solve?

Hey @modanesh , sure thing:
#4612
and the specific ones are these:

@modanesh modanesh linked an issue Oct 16, 2022 that may be closed by this pull request
@modanesh modanesh removed a link to an issue Oct 16, 2022
This was linked to issues Oct 16, 2022
@modanesh
Copy link
Contributor

As the test-frontend-jax reports, all added functions fail with this error: got an unexpected keyword argument 'x'. Could you take a look at it?

@Torus403
Copy link
Contributor Author

@modanesh Hey apologies for the back and forth, I think i have fixed it now. Any way to get the tests to rerun? Many thanks for all your help.

@modanesh
Copy link
Contributor

No worries. Resolving conflicts should do the trick.

@modanesh modanesh merged commit fa2af7a into ivy-llc:master Oct 16, 2022
@Torus403
Copy link
Contributor Author

Hey @modanesh just wanted to thank you for all your help!!! this was my first commit so hopefully it will go smoother next time. Thanks again :)

@modanesh
Copy link
Contributor

No problem :) You did a good job for your first PR. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arcsinh arcsin arccosh arccos
3 participants