Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prod at numpy_frontend #5714

Closed
wants to merge 0 commits into from
Closed

add prod at numpy_frontend #5714

wants to merge 0 commits into from

Conversation

AmeenUrRehman
Copy link
Contributor

Issue no. #5713

@AmeenUrRehman
Copy link
Contributor Author

@juliagsy plz check this could we ready to merge. Thank You !!!

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Oct 14, 2022
@AmeenUrRehman
Copy link
Contributor Author

@juliagsy hey, could we merge this plz check !!!

juliagsy
juliagsy suggested changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Great work so far! Just some small changes on formatting and keyword args, please also ensure that tests are passing!

As usual, please request my review again when you're done! Thanks!

ivy/functional/frontends/numpy/ndarray/ndarray.py Outdated Show resolved Hide resolved
ivy/functional/frontends/numpy/ndarray/ndarray.py Outdated Show resolved Hide resolved
@AmeenUrRehman
Copy link
Contributor Author

@juliagsy hey, thanks I have fixed the issues could you plz check this !!!

juliagsy
juliagsy suggested changes Oct 16, 2022
View reviewed changes
Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the changes! Great work so far! I've just realised, a test is needed for this instance method in the ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py file

If the tests are passing, you'll be good to go soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliagsy juliagsy juliagsy requested changes

Assignees

@juliagsy juliagsy

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmeenUrRehman @juliagsy @ivy-leaves