Sort #9885
Sort #9885
Conversation
|
Close #9852 |
There was a problem hiding this comment.
Hey!
Thank you soo much for contributing to ivy! 🙂
Your PR looks amazing ✨!
Actually there is one thing which you forgot about maybe, you have not added the test for the specific function. I'll link you to the guide which will help you explain in detail on how to add the test function.
https://lets-unify.ai/ivy/deep_dive/ivy_frontends_tests.html
Thanks! 🙂
There was a problem hiding this comment.
Awesome, thanks for the changes! 🙂
Just a few more changes required before we can merge your PR, I've mentioned them below!
You've mistakenly added both of the files on the main repo, they should rather be in their respective directories 🙂
- For your functional implementation it should be in
ivy/functional/frontends/jax/numpy/searching_sorting.py - Incase of the implementation of the test, it should be here,
ivy_tests/test_ivy/test_frontends/test_jax/test_jax_numpy_searching_sorting.py
Thanks! 🙂
ivy-leaves
added
the
JAX Frontend
There was a problem hiding this comment.
Your test is failing, there are some minor changes which need to be done.
There was a refactor in the frontend tests recently, you have to use test_flags now which handle multiple arguments.
I'll link you to an example which will help you in the refactor. https://github.com/unifyai/ivy/blob/master/ivy_tests/test_ivy/test_frontends/test_torch/test_linalg.py#L102
Thanks! 🙂
| stable: bool = True, | ||
| out: Optional[ivy.Array] = None, | ||
| ): | ||
| if axis == 1: |
There was a problem hiding this comment.
kindly debug your code from here as the difference is very minimal as the assertion error is [1 0] != [0 1], with the original framework, you are missing some logical implementation while implementing this
There was a problem hiding this comment.
No, I didn't forget but I am still trying to solve the problem every day.
Co-authored-by: zaeemansari70 [email protected]
Co-authored-by: zaeemansari70 [email protected]
Co-authored-by: zaeemansari70 [email protected]
Co-authored-by: zaeemansari70 [email protected]
|
What's the next step? @zaeemansari70 |
|
Hi @yumnaAlshalak , maybe text in the hiring channel on discord tagging the hiring team, they would have a better idea, I hope it helps 🙂 |
Close #9852