Add missing debug vars to debugAssertAllRenderVarsUnset (flutter#91848)

izaaz · Oct 14, 2021 · 9570d35 · 9570d35
1 parent ac745b3
commit 9570d35
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/packages/flutter/lib/src/rendering/debug.dart b/packages/flutter/lib/src/rendering/debug.dart
@@ -238,8 +238,12 @@ bool debugAssertAllRenderVarsUnset(String reason, { bool debugCheckIntrinsicSize
         debugPrintMarkNeedsPaintStacks ||
         debugPrintLayouts ||
         debugCheckIntrinsicSizes != debugCheckIntrinsicSizesOverride ||
+        debugProfileLayoutsEnabled ||
         debugProfilePaintsEnabled ||
-        debugOnProfilePaint != null) {
+        debugOnProfilePaint != null ||
+        debugDisableClipLayers ||
+        debugDisablePhysicalShapeLayers ||
+        debugDisableOpacityLayers) {
       throw FlutterError(reason);
     }
     return true;

diff --git a/packages/flutter/test/rendering/debug_test.dart b/packages/flutter/test/rendering/debug_test.dart
@@ -234,4 +234,28 @@ void main() {
     expect(opacityLayer.offset, const Offset(40, 40));
     debugDisableOpacityLayers = false;
   });
+
+  test('debugAssertAllRenderVarsUnset warns when debugProfileLayoutsEnabled set', () {
+    debugProfileLayoutsEnabled = true;
+    expect(() => debugAssertAllRenderVarsUnset('ERROR'), throwsFlutterError);
+    debugProfileLayoutsEnabled = false;
+  });
+
+  test('debugAssertAllRenderVarsUnset warns when debugDisableClipLayers set', () {
+    debugDisableClipLayers = true;
+    expect(() => debugAssertAllRenderVarsUnset('ERROR'), throwsFlutterError);
+    debugDisableClipLayers = false;
+  });
+
+  test('debugAssertAllRenderVarsUnset warns when debugDisablePhysicalShapeLayers set', () {
+    debugDisablePhysicalShapeLayers = true;
+    expect(() => debugAssertAllRenderVarsUnset('ERROR'), throwsFlutterError);
+    debugDisablePhysicalShapeLayers = false;
+  });
+
+  test('debugAssertAllRenderVarsUnset warns when debugDisableOpacityLayers set', () {
+    debugDisableOpacityLayers = true;
+    expect(() => debugAssertAllRenderVarsUnset('ERROR'), throwsFlutterError);
+    debugDisableOpacityLayers = false;
+  });
 }