Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print <header>, </header>, <span...> and <span> tags #28

Closed
getreu opened this issue Jun 11, 2024 · 3 comments · Fixed by #29
Closed

Do not print <header>, </header>, <span...> and <span> tags #28

getreu opened this issue Jun 11, 2024 · 3 comments · Fixed by #29

Comments

@getreu
Copy link

getreu commented Jun 11, 2024

You already ignore attributes in <span...> tags which is nice. Could you please also refrain from printing out the tags <span...> and </span> itself? It does not add any semantics to the resulting Markdown, but it adds a lot of garbage noise when converting automatically generated HTML.

Secondly, please also ignore the <header> and </header> tags in the output.

@izyuumi
Copy link
Owner

izyuumi commented Jun 12, 2024

I think I will do this by creating a wrapper function that takes in parameters to be passed when processing.

@izyuumi
Copy link
Owner

izyuumi commented Jun 13, 2024

@getreu Could you provide some short example snippets of code I could use to perform tests?

@getreu
Copy link
Author

getreu commented Jun 14, 2024

@izyuumi

On Wed, 2024-06-12 at 23:04 -0700, Yumi Izumi wrote:

@getreu Could you provide some short example snippets of code I could
use to perform tests?

Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

<!DOCTYPE html><p dir="auto" style="unicode-bidi: plaintext; caret-
color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: Cantarell; font-
size: 14.705309px; font-style: normal; font-variant-caps: normal; font-
weight: 400; letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0,
0.4); -webkit-text-stroke-width: 0px; text-decoration: none;"><a
class="user-mention notranslate" data-hovercard-type="user" data-
hovercard-url="/users/getreu/hovercard" data-octo-click="hovercard-
link-click" data-octo-dimensions="link_type:self"
href="https://github.com/getreu" title="Click to open
https://github.com/getreu">@getreu</a><span class="Apple-converted-
space"> </span>Could you provide some short example snippets of code I
could use to perform tests?</p><p style="unicode-bidi: plaintext; font-
family: Cantarell; font-style: normal; font-variant-caps: normal; font-
weight: 400; letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0,
0.4); -webkit-text-stroke-width: 0px; text-decoration: none; font-size:
small; color: rgb(102, 102, 102);"><br>Reply to this email
directly,<span class="Apple-converted-space"> </span><a
href="https://github.com/izyuumi/html2md-rs/issues/28#issuecomment-2164514483
" title="Click to open
https://github.com/izyuumi/html2md-rs/issues/28#issuecomment-2164514483
">view it on GitHub</a>, or<span class="Apple-converted-
space"> </span><a
href="https://github.com/notifications/unsubscribe-auth/AAENM"
title="Click to open
https://github.com/notifications/unsubscribe-auth/DAEFM">unsubscribe</a
>.<br>You are receiving this because you were mentioned.<img
src="https://github.com/notifications/beacon/AA3N0C.gif" height="1"
width="1" alt=""></p>

izyuumi added a commit that referenced this issue Jun 21, 2024
izyuumi pushed a commit that referenced this issue Jun 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.9.0](v0.8.2...v0.9.0)
(2024-06-21)


### Features

* custom configuration for how to render md
([2fd820a](2fd820a)),
closes [#28](#28)


### Bug Fixes

* fix cargo clippy issues
([32b5a9c](32b5a9c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants