Remove context path override prefix when handling a request #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the real path to the resource is extracted properly
albanf
force-pushed
the
remove-context-path-override-on-request
branch
from
ed29c29 to
007fc66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the context path override is used, binary resources are not resolved properly to real file path, because the prefix is not removed from the request.
For instance if the prefix is defined as "/prefix", the request to an image could be:
/prefix/cb4294738625/css/images/myimage.png
And the resource which is loaded is /prefix//css/images/myimage.png (after removing the cache buster part).
This PR removes the prefix as soon as the request comes in.