Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate RulesEngineBuilder #126

Closed
fmbenhassine opened this issue Dec 16, 2017 · 0 comments
Closed

Deprecate RulesEngineBuilder #126

fmbenhassine opened this issue Dec 16, 2017 · 0 comments
Assignees
@fmbenhassine
Labels
enhancement
Milestone
3.1.0

Comments

@fmbenhassine
Copy link
Member

The RuleEngineBuilder has no more added value now that DefaultRulesEngine class is public.
One of the goals of the builder was to return a package-private implementation of RulesEngine.

Now that there are two implementations of RulesEngine interface, having a generic builder or two builders makes no sense.

The RulesEngineBuilder will be deprecated in v3.1 and removed in v3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmbenhassine fmbenhassine

Labels
enhancement
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@fmbenhassine