Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AbstractRulesEngine public #238

Closed
MatiWalk opened this issue Nov 8, 2019 · 4 comments
Closed

Make AbstractRulesEngine public #238

MatiWalk opened this issue Nov 8, 2019 · 4 comments
Milestone

Comments

@MatiWalk
Copy link

MatiWalk commented Nov 8, 2019

Hey, first of all, great library! We are thinking on using this on our project.

Could we make AbstractRuleEngine public? right now it's only package accessible and it'd be cool to add new custom implementations to that base code. Perhaps making the other implementations not final could also work.

Thanks in advance!

@MatiWalk
Copy link
Author

Adding to the above, I'm seeing DefaultRuleListener is also not public, so there's no way of using it on a custom engine

fmbenhassine added a commit that referenced this issue Nov 13, 2019
@fmbenhassine
Copy link
Member

Hi @MatiWalk ,

Hey, first of all, great library! We are thinking on using this on our project.

Thank you! I'm glad you like Easy Rules!

I made AbstractRulesEngine public, it makes sense to me.

In regards to DefaultRuleListener, it has been removed in #223 .

@fmbenhassine fmbenhassine added this to the 4.0.0 milestone Nov 13, 2019
@fmbenhassine fmbenhassine changed the title Make AbstractRuleEngine public Make AbstractRulesEngine public Nov 13, 2019
@MatiWalk
Copy link
Author

Thank you so much!

any expected release date for 3.4?

@fmbenhassine
Copy link
Member

I did not set a release date, but it should be out soon (probably by the end of November). Keep tuned 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants