Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this commit fix bug if i try to put null value for one fact #137

Merged
merged 3 commits into from
Mar 27, 2018
Merged

this commit fix bug if i try to put null value for one fact #137

merged 3 commits into from
Mar 27, 2018

Conversation

bpoussin
Copy link
Contributor

this PR fix bug if i try to put null value for one fact in Facts object
and use annotation parameter method for action/condition method

@bpoussin
this commit fix bug if i try to put null value for one fact in Facts …
13723a8 
…object

and use annotation parameter method for action/condition method
@coveralls
Copy link

coveralls commented Feb 21, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 89.157% when pulling 92f562e on bpoussin:bp-fix-fact-with-null-value into 2022c4b on j-easy:master.

@fmbenhassine
Copy link
Member

Hi,

Thank you for your PR! Can you please add a test for this case?
Many thanks upfront.

Kr
Mahmoud

@bpoussin bpoussin mentioned this pull request Mar 1, 2018
Closed
@fmbenhassine
Copy link
Member

Hi @bpoussin ,

Thank you for updating the PR with these tests!
I will merge it asap and include it in the next release.

Best regards,
Mahmoud

@fmbenhassine fmbenhassine merged commit cbf5eee into j-easy:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpoussin @coveralls @fmbenhassine