Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnumTag support #31

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add EnumTag support #31

merged 2 commits into from
Feb 13, 2024

Conversation

garethj2
Copy link
Contributor

Adds support for parsing an encoding enums. Includes support for handling enumMeta.

Encoding and decoding for enum defs will be handled separately.

Copy link
Contributor

@jaxgzz jaxgzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@riccardoleder riccardoleder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I only left a couple of comments related to the creation based on the grid.

@garethj2 garethj2 merged commit 85578c1 into master Feb 13, 2024
1 check passed
@garethj2 garethj2 deleted the feature/STK-2242-add-enum-support branch February 13, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants