Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stk 3020 upgrade haystack 4 #37

Merged
merged 12 commits into from
Jan 6, 2025

Conversation

garethj2
Copy link
Contributor

@garethj2 garethj2 commented Jan 2, 2025

A long overdue upgrade of haystack core to make it up to date with the latest haystack standard.

Please see these proposals that have now been implemented (except https://project-haystack.org/forum/topic/937)...

This proposal has these sub-proposals that have now been implemented...

935: simplify how choices work for the common case to so that they work like all other tags
936: redesign how choices work for the complicated specialization use case via a new design pattern using the of tag
938: finalize the question mark inference operator in filter syntax
939: remove the equipFunction taxonomy until we learn more

Please note this proposal has not been implemented as the changes haven't yet made it into the main haystack-defs repo...

937: redesign ref of (domain/referent of the relationship) to use filters and eliminate the fluid-xxx def explosion

Overall the main biggest changes are...

  • Reworked choices (minor).
  • Refactor how defs are used in the automated tests. Switched from using hard coded files. This will make it easier for future changes to defs.
  • Reworked relationship haystack filter query.
  • Removed implied tags support. It was an experiment and no-one uses it.

Please note, when we release this change, I'll make it a new major version since it relies on a newer version of haystack defs.

spec/readDefs.ts Outdated Show resolved Hide resolved
spec/readDefs.ts Outdated Show resolved Hide resolved
@garethj2 garethj2 merged commit f9b14d4 into master Jan 6, 2025
1 check passed
@garethj2 garethj2 deleted the feature/STK-3020-upgrade-haystack-4 branch January 6, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants