styles: add page size, review margins #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weasy print's css supports the @page 'size' attribute, allowing us to specify a pdf size different from the default A4 size. The remarkable is 1872 x 1404 pixels, but using that makes fonts too small without further adjusments so setting a page size of half that is easier to use. Having a proper page size, we can re-adjust the margins to better fit the new format. Also made the space between columns in FifthAvenue slightly bigger as a matter of taste. Fixes: j6k4m8#75
|
This is so awesome @martinetd!! Thank you so much for contributing! Pending these status checks, I'll merge it in :D 🎉 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 33.28% 33.28%
=======================================
Files 19 19
Lines 688 688
=======================================
Hits 229 229
Misses 459 459 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weasy print's css supports the @page 'size' attribute, allowing us to specify a pdf size different from the default A4 size.
The remarkable is 1872 x 1404 pixels, but using that makes fonts too small without further adjusments so setting a page size of half that is easier to use.
Having a proper page size, we can re-adjust the margins to better fit the new format. Also made the space between columns in FifthAvenue slightly bigger as a matter of taste.
Fixes: #75
Sorry for the delay, here's the PR. Since I brought it up in the issue I've also done a similar modification to Academy as some documents render better with a single column.
The margins are up to discussion (sorry for switching to metrics, I couldn't understand inches if my life depends on it -- might want to switch to something like em for compromise if you're similar the other way around :P) ; I honestly didn't spend very long fiddling with them.
I'd attach a sample document with that but github doesn't seem to allow attachments here, so I guess we'll do without...