-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gcc devshell #84
Gcc devshell #84
Conversation
FFS ... |
... because it doesn't have meaning in GHA, I invented it as a convenient name (for use in |
79a4db7
to
118e640
Compare
We now have this matrix: continue-on-error: ${{ matrix.devshell == 'gcc' }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, macos-12]
py: [311]
devshell: [ clang, gcc ] so 4 jobs run (2 OSes x 2 compilers), and those on gcc are allowed to fail. Curiously, the gcc job only fails on Linux, not Darwin. Is this because on macOS we're compiling with clang, even when in the gcc environment? One slight wart is that we run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this one thing
Yes. |
I've lost track. Do we want to do anything more with this, or shall we merge? |
We want to skip the test, right? |
I must be missing something: I don't see what this test has to do with this PR. What's more, it seems to be failing on master. |
Ugh, nothing. I got lost in the many conversations. This can be merged.
Ugh x2. Now I'm puzzled. |
Yup, me too. |
I'm trying to undo the |
I've just push a disabling of that test. It's getting in the way too much, right now. |
I've also pushed this. |
Adds a second devShell which uses gcc instead of clang. This means we can now do
nix develop <path-to-flake>
nix develop <path-to-flake>#gcc
nix develop <path-to-flake>#clang
1&3 give a clang environment, 2 gives a gcc environment.
This could be useful for users who have a strong preference, but, above all, for allowing us to test both gcc and clang on GHA.
However, I'm unsure about how we should organize the workflows? Specifically, should the gcc and clang tests be run in
?
Note: this sits on top of the as-yet-unmerged #82.
Closes #17.