Fix salesagility#4646 - Hard coded messages in Surveys module

jack7anderson7 · Oct 19, 2022 · c03d31c · c03d31c
1 parent 7b6ac1b
commit c03d31c
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 25 deletions.
diff --git a/modules/Surveys/language/en_us.lang.php b/modules/Surveys/language/en_us.lang.php
@@ -91,4 +91,18 @@
     'LBL_SURVEYS_SURVEYQUESTIONS_FROM_SURVEYQUESTIONS_TITLE' => 'Survey Questions',
     'LBL_SURVEYS_SURVEYRESPONSES_FROM_SURVEYRESPONSES_TITLE' => 'Survey Responses',
     'LBL_SHOW_RESPONSES' => 'Show responses',
+    'LBL_SURVEY_QUESTION' => 'Question',
+    'LBL_SURVEY_TEXT' => 'Text',
+    'LBL_SURVEY_TYPE' => 'Type',
+    'LBL_SURVEY_ACTIONS' => 'Actions',
+    'LBL_SURVEY_NEW_QUESTION' => 'New Question',
+    'LBL_SURVEY_RESPONSES' => 'New Question',
+    'LBL_SURVEYS_SENT' => 'Surveys Sent:',
+    'LBL_SURVEY_DISTINCT' => 'Distinct Surveys Sent:',
+    'LBL_DRAFT' => 'Draft',
+    'LBL_SUBMIT' => 'Submit',
+    'LBL_SATISFIED_RESPONSE' => 'Satisfied',
+    'LBL_NOT_SATISFIED_NOR_DISSATISFIED' => 'Neither Satisfied nor Dissatisfied',
+    'LBL_DISSATISFIED' => 'Dissatisfied',
+    'LBL_STARS' => 'Stars'
 );
diff --git a/modules/Surveys/tpls/detailsurveyquestions.tpl b/modules/Surveys/tpls/detailsurveyquestions.tpl
@@ -3,13 +3,13 @@
     <table id="questionTable" class="table table-bordered">
         <tr>
             <th>
-                Question
+                {$MOD.LBL_SURVEY_QUESTION}
             </th>
             <th>
-                Text
+                {$MOD.LBL_SURVEY_TEXT}
             </th>
             <th>
-                Type
+                {$MOD.LBL_SURVEY_TYPE}
             </th>
         </tr>
         {foreach from=$questions item=question}

diff --git a/modules/Surveys/tpls/editsurveyquestions.tpl b/modules/Surveys/tpls/editsurveyquestions.tpl
@@ -2,19 +2,19 @@
     <input type="hidden" name="survey_questions_supplied" value="1">
     <table id="questionTable" class="table table-bordered">
         <tr>
-            <th>
-                Question
-            </th>
-            <th>
-                Text
-            </th>
-            <th>
-                Type
-            </th>
-            <th>Actions</th>
+          <th>
+            {$MOD.LBL_SURVEY_QUESTION}
+          </th>
+          <th>
+            {$MOD.LBL_SURVEY_TEXT}
+          </th>
+          <th>
+            {$MOD.LBL_SURVEY_TYPE}
+          </th>
+            <th>{$MOD.LBL_SURVEY_ACTIONS}</th>
         </tr>
     </table>
-    <button type="button" class="button" id="newQuestionButton">New Question</button>
+    <button type="button" class="button" id="newQuestionButton">{$MOD.LBL_SURVEY_NEW_QUESTION}</button>
 </div>
 {literal}
 <script>
@@ -175,4 +175,4 @@
   });
 
 </script>
-{/literal}
+{/literal}
diff --git a/modules/Surveys/tpls/reports.tpl b/modules/Surveys/tpls/reports.tpl
@@ -1,15 +1,15 @@
 <h1>{$survey.name}</h1>
 <table>
     <tr>
-        <th>Responses:</th>
+        <th>{$MOD.LBL_SURVEY_RESPONSES}</th>
         <td>{$responsesCount}</td>
     </tr>
     <tr>
-        <th>Surveys Sent:</th>
+        <th>{$MOD.LBL_SURVEYS_SENT}</th>
         <td>{$surveysSent}</td>
     </tr>
     <tr>
-        <th>Distinct Surveys Sent:</th>
+        <th>{$MOD.LBL_SURVEY_DISTINCT}</th>
         <td>{$surveysSentDistinct}</td>
     </tr>
 </table>

diff --git a/modules/Surveys/vardefs.php b/modules/Surveys/vardefs.php
@@ -50,7 +50,7 @@
             'vname'                     => 'LBL_STATUS',
             'type'                      => 'enum',
             'massupdate'                => 0,
-            'default'                   => 'Draft',
+            'default'                   => 'LBL_DRAFT',
             'no_default'                => false,
             'comments'                  => '',
             'help'                      => '',
@@ -111,31 +111,31 @@
             'vname'      => 'LBL_SUBMIT_TEXT',
             'type'       => 'varchar',
             'massupdate' => 0,
-            'default'    => 'Submit',
+            'default'    => 'LBL_SUBMIT',
         ),
         'satisfied_text'           => array(
             'required'   => false,
             'name'       => 'satisfied_text',
             'vname'      => 'LBL_SATISFIED_TEXT',
             'type'       => 'varchar',
             'massupdate' => 0,
-            'default'    => 'Satisfied',
+            'default'    => 'LBL_SATISFIED_RESPONSE',
         ),
         'neither_text'             => array(
             'required'   => false,
             'name'       => 'neither_text',
             'vname'      => 'LBL_NEITHER_TEXT',
             'type'       => 'varchar',
             'massupdate' => 0,
-            'default'    => 'Neither Satisfied nor Dissatisfied',
+            'default'    => 'LBL_NOT_SATISFIED_NOR_DISSATISFIED',
         ),
         'dissatisfied_text'        => array(
             'required'   => false,
             'name'       => 'dissatisfied_text',
             'vname'      => 'LBL_DISSATISFIED_TEXT',
             'type'       => 'varchar',
             'massupdate' => 0,
-            'default'    => 'Dissatisfied',
+            'default'    => 'LBL_DISSATISFIED',
         ),
         "surveys_surveyquestions"  => array(
             'name'         => 'surveys_surveyquestions',

diff --git a/modules/Surveys/views/view.reports.php b/modules/Surveys/views/view.reports.php
@@ -182,12 +182,14 @@ private function getChoiceQuestionSkeleton($arr, $options)
 
     private function getRatingQuestionSkeleton($arr)
     {
+        global $mod_strings;
+
         for ($x = 1; $x <= 5; $x++) {
-            $arr['chartLabels'][$x] = $x . ' Stars';
+            $arr['chartLabels'][$x] = $x . $mod_strings['LBL_STARS'];
             $arr['chartData'][$x] = 0;
             $arr['responses'][$x] = array(
                 'count' => 0,
-                'label' => $x . ' Stars',
+                'label' => $x . $mod_strings['LBL_STARS'],
                 'order' => $x
             );
         }