Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build on 32-bit Windows #1540

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix build on 32-bit Windows #1540

merged 1 commit into from
Mar 7, 2023

Conversation

drakkan
Copy link
Contributor

@drakkan drakkan commented Mar 5, 2023

I've included #1525 in SFTPGo. Manual tests are ok and SFTPGo test suite passes too, thanks for improving Windows support!
However CI fails with this error

C:\Users\runneradmin\go\pkg\mod\github.com\jackc\pgx\[email protected]\internal\nbconn\nbconn_real_non_block_windows.go:27:33: cannot use 0x8004667e (untyped int constant 2147772030) as int value in constant declaration (overflows)

https://github.com/drakkan/sftpgo/actions/runs/4336134809/jobs/7571210333

CI builds SFTPGo for amd64, arm64 and 386. This patch fixes the 32-bit build

@jackc jackc merged commit 19039e6 into jackc:master Mar 7, 2023
@jackc
Copy link
Owner

jackc commented Mar 7, 2023

Thanks!

@drakkan drakkan deleted the 32bit branch June 15, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants