Skip to content

Commit

Permalink
qt: remove unused QT_BITBOX_ALLOW_EXTERNAL_URLS
Browse files Browse the repository at this point in the history
Introduced in 8a27bfe to enable the
in-app lociz editor, which was removed again in 29a0764.
  • Loading branch information
benma committed Oct 12, 2022
1 parent 4e4e78d commit d739c60
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
6 changes: 0 additions & 6 deletions frontends/qt/BitBox.pro
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ win32 {
QMAKE_CXXFLAGS += $$CMISC
}

# Pass on env var as a define.
QT_BITBOX_ALLOW_EXTERNAL_URLS = $$(QT_BITBOX_ALLOW_EXTERNAL_URLS)
equals(QT_BITBOX_ALLOW_EXTERNAL_URLS, 1) {
DEFINES += QT_BITBOX_ALLOW_EXTERNAL_URLS
}

# https://stackoverflow.com/questions/18462420/how-to-specify-mac-platform-in-qmake-qtcreator
unix:!macx {
QMAKE_LFLAGS_RPATH=
Expand Down
4 changes: 0 additions & 4 deletions frontends/qt/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@ class RequestInterceptor : public QWebEngineUrlRequestInterceptor {
public:
explicit RequestInterceptor() : QWebEngineUrlRequestInterceptor() { }
void interceptRequest(QWebEngineUrlRequestInfo& info) override {
#ifdef QT_BITBOX_ALLOW_EXTERNAL_URLS
// Do not block anything.
return;
#endif
// Do not block qrc:/ local pages or js blobs
if (info.requestUrl().scheme() == "qrc" || info.requestUrl().scheme() == "blob") {
return;
Expand Down

0 comments on commit d739c60

Please sign in to comment.