Theme selection "Auto" on new login is very dark. #549
Comments
|
I am unable to replicate this on Windows 10 + Firefox 76. What OS are you using, and have you performed a forced refresh or cleared your browser cache? |
|
Here is Windows 10 + Firefox 76.0.1. Did a clear cache and same issue. Also tried with Edge (which I never used before), same issue. Tried on a few other different machines with Firefox and same issue. My installation was originally 3.46 which was fine. The issue started right after my upgrade to 3.49 using sudo python3 -m pip install --upgrade Mopidy-Iris. The installation is inside a VM and I had made a snapshot before upgrade. I went back to 3.46 using my snapshot and its fine, no color issues. Anything else you would like me to try |
|
I've finally managed to replicate this, but only with a rather old Microsoft Edge 44. This seemed to be due to the browser not supporting |
|
I believe I found the issue. See: https://codepen.io/kleinfreund/pen/NmpKZM My browser returns no (false) on the link above. according to https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme : Indicates that the user has made no preference known to the system. This keyword value evaluates to false in the boolean context. Is no-preference (false) handled as dark ? |
|
Yep you've hit the nail on the head. There isn't currently any proper handling of |
* Display general Spotify error messages that are provided by API * Calculating group volume on render rather than on load, fixes jaedb#534 * Removing group when last client is removed from it * Properly cancellable processes; Playlists that refuse to load tracks * Removing data_dir in favor of Extension.get_data_dir, jaedb#547 * Creating SearchResults component * Search results grid layout; Tracklist * Clearable search results * Ditching thumbnail glow on mobile - performance suffering too much * Play/queue actions on playlist save tracks to index for faster reuse * Fixing context menu trigger silencing; Search form polish * Letter spacing * Fixing theme tweaks; Fixing prefers-color-scheme of false, resolves jaedb#549 * Buildout * Black and flake fixups (still no check_manifest working reliably) * Removing old helpers * Fill prop for thumbnails on Queue and Artist for large screens * Getting a feel for desired multi-language approach jaedb#424 * Language as window.language for access in pure function * Exposing components for translation mapping; Queue and AAlbum views now moved to translation file * Renaming Content to I18n to avoid naming clashes; Artist and Debug views mapped * Mapping Playlist view * Clickable flags; Adding links to version release notes * Merging into main dev stream * Mapping all remaining views - just modals and components to go * All views done this time; Language file mapping for modals.. Will need to do destructuring in second sweep * Halfway through modals mapping * Final components done, dynamic language selector * Adding error boundary around Notifications to catch issues like jaedb#565 * Responsive for < 350px devices, fixes jaedb#532 * Prod buildout * Correcting snapcast config and path * Updating with corrected Snapserver config file path * Mobile polish; Performance experimentation; Loader screen; ; Minor code bugs * Previewing items to add, in prep for random selection (jaedb#546) * Fixing library URI setting (destructuring), possibly related to jaedb#571 * Adding generic loadItem (refactor elsewhere); Adding foundation for Add Random * Modal detection through less-than-ideal jQuery * Add to queue random functional * Adding jest coverage * Added sv.yaml This is the first version of a Swedish translation for Iris. * Upgrading jest * Add German translations * Upgrading to Babel 7; Fixing failing tests * Disable lifecycle methods * Buildout * 3.51 buildout * Adding jest to ci jobs * Adding Code Climate coverage reporter Co-authored-by: James Barnsley <[email protected]> Co-authored-by: el97 <[email protected]> Co-authored-by: Fabian Dennler <[email protected]>
* Display general Spotify error messages that are provided by API * Calculating group volume on render rather than on load, fixes jaedb#534 * Removing group when last client is removed from it * Properly cancellable processes; Playlists that refuse to load tracks * Removing data_dir in favor of Extension.get_data_dir, jaedb#547 * Creating SearchResults component * Search results grid layout; Tracklist * Clearable search results * Ditching thumbnail glow on mobile - performance suffering too much * Play/queue actions on playlist save tracks to index for faster reuse * Fixing context menu trigger silencing; Search form polish * Letter spacing * Fixing theme tweaks; Fixing prefers-color-scheme of false, resolves jaedb#549 * Buildout * Black and flake fixups (still no check_manifest working reliably) * Removing old helpers * Fill prop for thumbnails on Queue and Artist for large screens * Getting a feel for desired multi-language approach jaedb#424 * Language as window.language for access in pure function * Exposing components for translation mapping; Queue and AAlbum views now moved to translation file * Renaming Content to I18n to avoid naming clashes; Artist and Debug views mapped * Mapping Playlist view * Clickable flags; Adding links to version release notes * Merging into main dev stream * Mapping all remaining views - just modals and components to go * All views done this time; Language file mapping for modals.. Will need to do destructuring in second sweep * Halfway through modals mapping * Final components done, dynamic language selector * Adding error boundary around Notifications to catch issues like jaedb#565 * Responsive for < 350px devices, fixes jaedb#532 * Prod buildout * Correcting snapcast config and path * Updating with corrected Snapserver config file path * Mobile polish; Performance experimentation; Loader screen; ; Minor code bugs * Previewing items to add, in prep for random selection (jaedb#546) * Fixing library URI setting (destructuring), possibly related to jaedb#571 * Adding generic loadItem (refactor elsewhere); Adding foundation for Add Random * Modal detection through less-than-ideal jQuery * Add to queue random functional * Adding jest coverage * Added sv.yaml This is the first version of a Swedish translation for Iris. * Upgrading jest * Add German translations * Upgrading to Babel 7; Fixing failing tests * Disable lifecycle methods * Buildout * 3.51 buildout * Adding jest to ci jobs * Adding Code Climate coverage reporter Co-authored-by: James Barnsley <[email protected]> Co-authored-by: el97 <[email protected]> Co-authored-by: Fabian Dennler <[email protected]>
Describe the bug
When logging in to 3.49, the auto theme selection seems broken on Firefox.
To Reproduce
Login in private mode and proceed with new client
Screenshot
After login, go to settings. Auto is selected.
Select dark and the colors come back normal and readable:
The text was updated successfully, but these errors were encountered: