Fix selection ordering #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Can you please split this into separate PRs? Dependency upgrades really need to be in their own PR, otherwise things get very muddy very quickly. The fix for #861 looks good though, so if you can get this split out today I can merge it in for the next release. |
jaedb
requested changes
Sep 3, 2022
nawordar
force-pushed
the
fix-selection
branch
from
18fc5d9 to
86a6ade
Compare
|
I removed the package-lock.json changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #861
I also updated package-lock.json, because it was desynchronized for some reason, and added
/build/to .gitignore, aspip install --user .creates that directory.