Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for link parameter formatting #807

Merged

Conversation

drewcorlin1
Copy link
Contributor

Which problem is this PR solving?

Documentation associated with jaegertracing/jaeger-ui#2501

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit ec73975
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/674cd706e4ffe7000884af8c
😎 Deploy Preview https://deploy-preview-807--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yurishkuro
Copy link
Member

please amend the commit with sing-off git commit -s --amend

@drewcorlin1 drewcorlin1 force-pushed the link-paramter-formatting branch 2 times, most recently from 44c2274 to 3a84cce Compare November 30, 2024 19:17
@yurishkuro
Copy link
Member

Please check linters

@drewcorlin1 drewcorlin1 force-pushed the link-paramter-formatting branch from 3a84cce to 969453e Compare December 1, 2024 17:47
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's combine with add function in one change

content/docs/next-release-v2/frontend-ui.md Outdated Show resolved Hide resolved
@drewcorlin1 drewcorlin1 force-pushed the link-paramter-formatting branch from 969453e to 3a5edbe Compare December 1, 2024 20:23
@drewcorlin1 drewcorlin1 force-pushed the link-paramter-formatting branch from 3a5edbe to ec73975 Compare December 1, 2024 21:37
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 3dbd3ef into jaegertracing:main Dec 1, 2024
12 checks passed
@drewcorlin1
Copy link
Contributor Author

thanks for all the reviews @yurishkuro !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants