[jaeger] Add security context to deployment charts in jaeger #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naseemkullah @pavelnikolov @dvonthenen Can i get a review on this please. |
naseemkullah
requested changes
Jan 23, 2020
naseemkullah
changed the title
mehta-ankit
force-pushed
the
addSecurityContext
branch
2 times, most recently
from
769ea70 to
863953d
Compare
naseemkullah
approved these changes
Jan 24, 2020
|
Please gpg sign all you commits @mehta-ankit |
naseemkullah
requested changes
Jan 24, 2020
mehta-ankit
force-pushed
the
addSecurityContext
branch
3 times, most recently
from
4fe79ac to
9091bff
Compare
|
@naseemkullah I rebased to resolve conflicts and updated the version to 0.19.1. |
mehta-ankit
force-pushed
the
addSecurityContext
branch
from
9091bff to
dd512b4
Compare
|
Sure but we added a new component "ingester" could you add values for it please? |
Signed-off-by: Ankit Mehta <[email protected]>
Signed-off-by: Ankit Mehta <[email protected]>
mehta-ankit
force-pushed
the
addSecurityContext
branch
from
dd512b4 to
d5cd4b5
Compare
Sure. Added it to the ingester. Should be ready now. |
naseemkullah
approved these changes
Jan 25, 2020
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankit Mehta [email protected]
When deploying this chart in our cluster we found that we had to add security context to the deployments for them to run as non-root user.
So i created this PR where securityContext is added to the template/charts for deployment and its default value is provided in
values.yamlfile. These can be overwritten if someone uses jaeger chart as a dependency in their own values.yaml file.