Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-operator] Add ingressclasses to correct apiGroup #592

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[jaeger-operator] Add ingressclasses to correct apiGroup #592

merged 1 commit into from
Aug 7, 2024

Conversation

kravciak
Copy link
Contributor

@kravciak kravciak commented Jul 31, 2024 •
edited
Loading

What this PR does

Original fix added ingressclasses to extensions instead of networking.k8s.io

Which issue this PR fixes

Error in logs:

~ kubectl logs -n jaeger jaeger-operator-6867cc744c-6pq6z
W0731 09:34:51.891865       1 reflector.go:539] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: 
  failed to list *v1.IngressClass: ingressclasses.networking.k8s.io is forbidden:
  User "system:serviceaccount:jaeger:jaeger-operator" cannot list resource "ingressclasses" in API group "networking.k8s.io" at the cluster scope

E0731 09:34:51.891968       1 reflector.go:147] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: 
  Failed to watch *v1.IngressClass: failed to list *v1.IngressClass: ingressclasses.networking.k8s.io is forbidden:
  User "system:serviceaccount:jaeger:jaeger-operator" cannot list resource "ingressclasses" in API group "networking.k8s.io" at the cluster scope

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@kravciak kravciak requested review from batazor and cpanato as code owners July 31, 2024 08:28
@shivendoodeshmukh
Copy link
Contributor

Oh Cool, thank you

@kravciak kravciak mentioned this pull request Aug 6, 2024
Closed
@batazor batazor merged commit 26e6439 into jaegertracing:main Aug 7, 2024
2 checks passed
This was referenced Aug 7, 2024
Merged
Merged
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
@kravciak
Fix Update role.yaml to solve issue 581 (jaegertracing#592)
5bf976f 
Signed-off-by: Martin Kravec <[email protected]>
Signed-off-by: mehul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sereneshikari sereneshikari sereneshikari left review comments

@shivendoodeshmukh shivendoodeshmukh shivendoodeshmukh approved these changes

@batazor batazor Awaiting requested review from batazor batazor is a code owner

@cpanato cpanato Awaiting requested review from cpanato cpanato is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kravciak @shivendoodeshmukh @sereneshikari @batazor