Reproduce linting checks from the main repo #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danish9039 <[email protected]>
yurishkuro
reviewed
Jan 20, 2025
|
|
||
| - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 | ||
| lint: | ||
| needs: setup-scripts |
There was a problem hiding this comment.
needs: means this job will run after setup-scripts, but they do not share the file system
There was a problem hiding this comment.
how is this resolved? It's not going to work.
Signed-off-by: hippie-danish <[email protected]>
Signed-off-by: danish9039 <[email protected]>
yurishkuro
reviewed
Jan 22, 2025
yurishkuro
reviewed
Jan 22, 2025
yurishkuro
reviewed
Jan 22, 2025
yurishkuro
reviewed
Jan 22, 2025
Signed-off-by: danish9039 <[email protected]>
|
|
|
why are we not getting these errors in jaeger repo? |
because main jaeger repo uses |
|
the objective was to use the same settings as the main repo |
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: hippie-danish <[email protected]>
yurishkuro
reviewed
Jan 25, 2025
yurishkuro
reviewed
Jan 25, 2025
Signed-off-by: danish9039 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test