-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching spans in a trace page doesn't work #803
Comments
@RotemKir Can confirm in 1.25.0, the issue is also present in jaeger 1.24.0. |
I am a backend dev so i really have no real clue about react, but i'm pretty sure focusSpan() is never actually called and the span query is never updated. Passing the uiFind parameter in the URL unlocks the search menu buttons on the side, but once you use them, the input on the side is reset to the previously found span ID. |
I will take a look at this bug if thats okay with you guys?! |
Yup, I'm able to reproduce with the latest build as well. No one has claimed this so it's yours, @w0wka91 :) |
The problem is related to incompatible versions of react-router-redux and react-router-dom. |
Signed-off-by: Waldemar Penner <[email protected]>
Signed-off-by: Waldemar Penner <[email protected]>
Any update on this ? |
being addressed in #837 |
* Downgrade react-router-dom (#803) Signed-off-by: Waldemar Penner <[email protected]> * Update Snapshots (#803) Signed-off-by: Waldemar Penner <[email protected]> Co-authored-by: Ruben Vargas <[email protected]>
## Which problem is this PR solving? - part of: #1825 - Upgrades react-router-dom to v5.2.0 ## Description of the changes - This PR upgrades the rrd to v5.2.0 - This upgrade was previously attempted with PR #727 but at that time, an issue (#803) was reported because `react-router-redux` v5.x was not compatible with rrd v5.2.0, so it was reverted with PR: #837 - Now, since we have `redux-first-history` instead of `react-router-redux`, we can upgrade to rrd v5.2.0 safely now. ## How was this change tested? - The reported issue with v5.2.0 (#803) is not being reproduced now.  ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Ansh Goyal <[email protected]>
Describe the bug
Open a specific trace and enter a span id in the "Find..." textbox does nothing.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When searching a span id the span should be marked and found (nice to have: a message if nothing was found).
Screenshots

Entering span id (nothing happens):
Refreshing the screen with the same url:

Version (please complete the following information):
What troubleshooting steps did you try?
Additional context
IIRC the search worked fine a few versions earlier, can't recall which version since I upgraded the docker image several times in the past month.
As a workaround refreshing the screen or navigating directly to the url with the trace and span ids works, just searching in the page seems broken.
The text was updated successfully, but these errors were encountered: