fix: Make popup on the Search input field less intrusive enhancement #1685
Conversation
|
I like it. But can you reduce the white space around it, so that the button looks the same as the others on the right? |
| overlayStyle={{ maxWidth: '600px' }} // This is a large tooltip and the default is too narrow. | ||
| title={renderTooltip()}> | ||
| <Button htmlType="button"><IoHelp className="SearchForm--hintTrigger" /></Button> | ||
| </Tooltip> | ||
| {navigable && ( | ||
| <> | ||
| <Button |
There was a problem hiding this comment.
it would be nice to have a mouseover tooltip on this button, it's not very intuitive what it's supposed to do. The up/down arrows are more obvious, as well as [x] button.
There was a problem hiding this comment.
@yurishkuro fixed.
Signed-off-by: Anik Dhabal Babu <[email protected]>
Signed-off-by: Anik Dhabal Babu <[email protected]>
|
you ticked the box, but are you sure you ran |
Signed-off-by: Anik Dhabal Babu <[email protected]>
sorry, silly mistake. I've fixed the lint and unit test. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1685 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 242 241 -1
Lines 7559 7560 +1
Branches 1984 1985 +1
=======================================
+ Hits 7258 7259 +1
Misses 301 301
☔ View full report in Codecov by Sentry. |
Which problem is this PR solving?
#1651
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test