Handled the case in which child span starts before and ends after parent span. #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t span Signed-off-by: GLVS Kiriti <[email protected]>
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
…ction Signed-off-by: GLVS Kiriti <[email protected]>
yurishkuro
reviewed
Sep 12, 2023
packages/jaeger-ui/src/components/TracePage/CriticalPath/index.test.js
Outdated
Show resolved
Hide resolved
yurishkuro
previously approved these changes
Sep 12, 2023
yurishkuro
reviewed
Sep 12, 2023
packages/jaeger-ui/src/components/TracePage/CriticalPath/index.test.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/TracePage/CriticalPath/index.test.js
Outdated
Show resolved
Hide resolved
|
Basically the first test is to test computeCriticalPath function. But memoizedTraceCriticalPath returns the same as computeCriticalPath function. Then should I remove the 2nd test case?? |
Updated sentence in the test case Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: GLVSKiriti <[email protected]>
|
I would remove the first one, it's calling internal implementation details which are irrelevant for the purpose of the test. |
Signed-off-by: GLVSKiriti <[email protected]>
Signed-off-by: GLVSKiriti <[email protected]>
yurishkuro
reviewed
Sep 12, 2023
Signed-off-by: GLVSKiriti <[email protected]>
Signed-off-by: GLVSKiriti <[email protected]>
yurishkuro
approved these changes
Sep 12, 2023
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above case is not handled in previous code
Resolves #1779