Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: remove ant-design/compatibility package #1853

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

anshgoyalevil
Copy link
Member

@anshgoyalevil anshgoyalevil commented Oct 6, 2023

Which problem is this PR solving?

Description of the changes

  • This PR removes the ant-design compatibility package from the project while keeping each component UI and UX as it was previously.

How was this change tested?

  • unit tests, and manually viewing each affected component.
  • Since, this PR affects the Search Form, Search Trace Form, and Trace Span Table View Filter Dropdowns, below is a screencast, showcasing the affected UIs
screen-capture.5.webm

Checklist

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...aeger-ui/src/components/App/TraceIDSearchInput.tsx 100.00% <ø> (ø)
...r-ui/src/components/SearchTracePage/SearchForm.jsx 92.15% <ø> (ø)
...i/src/components/TracePage/TraceSpanView/index.tsx 89.39% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 324c430 into jaegertracing:main Oct 6, 2023
@anshgoyalevil anshgoyalevil deleted the 1antd branch October 9, 2023 06:31
@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants