Track JS errors in GA #189
Conversation
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 90.86% 91.45% +0.59%
==========================================
Files 93 95 +2
Lines 1937 2130 +193
Branches 382 434 +52
==========================================
+ Hits 1760 1948 +188
- Misses 154 161 +7
+ Partials 23 21 -2
Continue to review full report at Codecov.
|
|
@simonrobb Can you look this over when you get the chance? |
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
src/index.js
Outdated
| import 'u-basscss/css/flexbox.css'; | ||
| import 'u-basscss/css/layout.css'; | ||
| import 'u-basscss/css/margin.css'; | ||
| import 'u-basscss/css/padding.css'; | ||
| import 'u-basscss/css/position.css'; | ||
| import 'u-basscss/css/typography.css'; | ||
|
|
||
| initTracking(); | ||
|
|
||
| const UI_ROOT_ID = 'jaeger-ui-root'; | ||
|
|
||
| /* istanbul ignore if */ | ||
| if (document && process.env.NODE_ENV !== 'test') { |
There was a problem hiding this comment.
Is it better to test for NODE_ENV !== 'test' or NODE_ENV === 'production'? Probably don't want to track events in staging environments etc, if they exist.
|
|
||
| import prefixUrl from '../prefix-url'; | ||
|
|
||
| const UNKONWN_SYM = { sym: '??', word: '??' }; |
There was a problem hiding this comment.
May as well fix this typo (UNKONWN) now.
Signed-off-by: Joe Farro <[email protected]>
scripts/get-tracking-version.js
Outdated
| @@ -0,0 +1,92 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| const spawnSync = require('child_process').spawnSync; | |||
There was a problem hiding this comment.
What's the purpose of this? Maybe a quick comment
| @@ -0,0 +1,202 @@ | |||
| # Google Analytics (GA) Tracking In Jaeger UI | |||
There was a problem hiding this comment.
Great write up Joe
Although I'm all for documentation my only comment would be, is it really worth to maintain all this stuff for Jaeger UI? Although this is nice to have, my concern is this information will go stale as its not really part of the core of what Jaeger provides.
There was a problem hiding this comment.
That's a valid point. But, it really shouldn't need to change much. Seems like low-maintenance docs, to me.
What do you suggest?
| @@ -0,0 +1,357 @@ | |||
| // @flow | |||
There was a problem hiding this comment.
I feel like this could be a library in itself outside of Jaeger
Signed-off-by: Joe Farro <[email protected]>
* Track errors in GA w raven-js; TODO: tests, readme Signed-off-by: Joe Farro <[email protected]> * Include CSS selector with last error breadcrumb Signed-off-by: Joe Farro <[email protected]> * README for GA error tracking Signed-off-by: Joe Farro <[email protected]> * Misc cleanup Signed-off-by: Joe Farro <[email protected]> * README info on GA Application Tracking Signed-off-by: Joe Farro <[email protected]> * Misc fix to tracking README Signed-off-by: Joe Farro <[email protected]> * Misc cleanup to raven message conversion to GA Signed-off-by: Joe Farro <[email protected]> * Tests for tracking Signed-off-by: Joe Farro <[email protected]> * Apply prettier to markdown files Signed-off-by: Joe Farro <[email protected]> * Run prettier on *.md files Signed-off-by: Joe Farro <[email protected]> * Add tracking.trackErrors feature flag to UI config Signed-off-by: Joe Farro <[email protected]> * Upgrade prettier, add doc for tracking.trackErrors Signed-off-by: Joe Farro <[email protected]> * Check for breadcrumbs when tracking errors Signed-off-by: Joe Farro <[email protected]> * Fix typo, remove unnecessary NODE_ENV guard Signed-off-by: Joe Farro <[email protected]> * Comments for get-tracking-version script Signed-off-by: Joe Farro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Fix #39.
TLDR: Using raven-js to capture errors and context info, then sending it to GA instead of sentry. It's a little out there, but it should be informative.
I did a pretty thorough write-up in
src/utils/tracking/README.md, which lays out the changes in this PR. It might make sense to move some of the README to the Jaeger docs. They need to be updated to reflectgaTrackingID↠tracking.gaIDand the addition oftracking.trackErrors, anyway.The changes in the
*.mdfiles that aren't related to GA tracking can be ignored; they're captured in #188.The version info generated for GA can also be used to satisfy #113. I'll add a footer in another PR.
I'm currently working on UX event tracking in a different branch.