Imported only lodash submodules #2033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
44
to
49
| const tags = _(availableTags).map('tags').flatten().value(); | ||
| let tagKeys = _(tags).map('key').uniq().value(); | ||
| tagKeys = _.filter(tagKeys, function calc(o) { | ||
| const tags = _map(availableTags).map('tags').flatten().value(); | ||
| let tagKeys = _map(tags).map('key').uniq().value(); | ||
| tagKeys = _map.filter(tagKeys, function calc(o) { |
There was a problem hiding this comment.
We aren't only using the _map submodule here. Others are also used like _uniq, _flatter, _concat.
A changed syntax would be something like:
const tags = _flatten(_map(availableTags, 'tags'));
let tagKeys = _uniq(_map(tags, 'key'));
...etc
Signed-off-by: MeenuyD <[email protected]>
Signed-off-by: MeenuyD <[email protected]>
|
It will go faster if you run yarn lint/test locally before submitting |
Comment on lines
+47
to
+49
| const tags = _flatten(availableTags).map('tags').flatten().value(); | ||
| let tagKeys = _uniq(tags).map('key').uniq().value(); | ||
| tagKeys = _map.filter(tagKeys, function calc(o) { |
There was a problem hiding this comment.
I think you have messed up the whole thing here. I think you should take the reference of official lodash docs for better understanding.
Comment on lines
+83
to
+85
| const tags = _flatten(allSpans).map('tags').flatten().value(); | ||
| const tagKeys = _uniq(tags).map('key').uniq().value(); | ||
| const values = _concat.concat(serviceName, operationName, tagKeys); |
| const temp = _.chain(allSpans) | ||
| const temp = _get.chain(allSpans) |
There was a problem hiding this comment.
chain is not a function provided by _get, rather is a submodule itself. Please check the comments above ^
|
I moved to files that were changed correctly into another PR, already merged. |
|
Ok thank you |
|
addressed in #2041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported only lodash submodules
#2032