-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDG: Add path agnostic decorations action & reducer #549
DDG: Add path agnostic decorations action & reducer #549
Conversation
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 93.00% 92.99% -0.02%
==========================================
Files 197 200 +3
Lines 4848 4923 +75
Branches 1177 1205 +28
==========================================
+ Hits 4509 4578 +69
- Misses 299 305 +6
Partials 40 40
Continue to review full report at Codecov.
|
Are there any visuals coming with this PR? |
Not in this one. This is just the functionality to fetch and store decoration values (and the max value for each decoration). |
* WIP: Action and types for decorations * Add PAD reducer, fix types, fix year * Fix and test reducer, fix types, fix another year * Add another pad reducer test * WIP: Begin testing action * WIP: Finish action tests TODO: Move stringSupplant * Move and test stringSupplant * Cleanup Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Which problem is this PR solving?
Short description of the changes