Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing trace quality menu title #592

Merged
merged 6 commits into from
Jun 10, 2020
Merged

Allow customizing trace quality menu title #592

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd4ed0a
Allow customizing Quality Metrics menu title
Jun 10, 2020
986fd15
Change default title
Jun 10, 2020
18d2631
Move defaults
Jun 10, 2020
9b230fc
prettier
Jun 10, 2020
487d18f
comment
Jun 10, 2020
9e67533
default
Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/App/TopNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ if (getConfigValue('qualityMetrics.menuEnabled')) {
NAV_LINKS.push({
to: qualityMetrics.getUrl(),
matches: qualityMetrics.matches,
text: 'Quality Metrics',
text: getConfigValue('qualityMetrics.menuLabel') || 'Trace Quality',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the config type definition here
and instead of || 'Trace Quality' please use the default config object

});
}

Expand Down