Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make proto is not working #1264

Closed
olivierboucher opened this issue Dec 25, 2018 · 1 comment
Closed

make proto is not working #1264

olivierboucher opened this issue Dec 25, 2018 · 1 comment

Comments

@olivierboucher
Copy link

olivierboucher commented Dec 25, 2018

Requirement - what kind of business use case are you trying to solve?

Having make proto work in order to create a PR introducing DependencyLink as a proto for #1214

Problem - what in Jaeger blocks you from solving the requirement?

make proto is not working, there are missing files and imports

Proposal - what do you suggest to solve the problem or improve the existing situation?

Look at PR #1263

Any open questions to address

Am I missing something here? According to #1260 master should be working

Outputs

Without the missing imports:

protoc \
                -I model/proto -I vendor/github.com/grpc-ecosystem/grpc-gateway -I vendor/github.com/gogo/googleapis -I vendor/github.com/gogo/protobuf \
                --gogo_out=plugins=grpc,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/duration.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/empty.proto=github.com/gogo/protobuf/types,Mgoogle/api/annotations.proto=github.com/gogo/googleapis/google/api,Mmodel.proto=github.com/jaegertracing/jaeger/model:/Users/olivierboucher/go/src/github.com/jaegertracing/jaeger/model/ \
                model/proto/model.proto
google/protobuf/descriptor.proto: File not found.
...

and then without the missing prune settings:

protoc \
                -I model/proto -I vendor/github.com/grpc-ecosystem/grpc-gateway -I vendor/github.com/gogo/googleapis -I vendor/github.com/gogo/protobuf/protobuf -I vendor/github.com/gogo/protobuf \
                --gogo_out=plugins=grpc,Mgoogle/protobuf/descriptor.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/duration.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/empty.proto=github.com/gogo/protobuf/types,Mgoogle/api/annotations.proto=github.com/gogo/googleapis/google/api,Mmodel.proto=github.com/jaegertracing/jaeger/model:/Users/olivierboucher/go/src/github.com/jaegertracing/jaeger/model/ \
                model/proto/model.proto
vendor/github.com/gogo/protobuf/protobuf: warning: directory does not exist.
google/protobuf/descriptor.proto: File not found.
...
@pavolloffay
Copy link
Member

See #1263 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants