[WIP] - Added missing imports and prune options for make proto to work #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Boucher <[email protected]>
olivierboucher
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1263 +/- ##
======================================
Coverage 100% 100%
======================================
Files 160 160
Lines 7181 7181
======================================
Hits 7181 7181Continue to review full report at Codecov.
|
|
@olivierboucher when you say "could not make I just ran it and it seems working fine, with the exception of a single test file that got changed (#1266). |
|
I see #1264, so I guess |
yurishkuro
reviewed
Dec 25, 2018
| -I vendor/github.com/gogo/protobuf | ||
| # Remapping of std types to gogo types (must not contain spaces) | ||
| PROTO_GOGO_MAPPINGS := $(shell echo \ | ||
| Mgoogle/protobuf/descriptor.proto=github.com/gogo/protobuf/types, \ |
|
I think this is already done, make proto works (at least for me locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Could not get
make prototo work without theses changes even though #1260 was merged.Short description of the changes
I will eventually commit the proto changes related to #1214 since we wanted to have a second PR.