Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Refactor HTTP/gRPC server creation out of main() #1482

Closed
yurishkuro opened this issue Apr 22, 2019 · 3 comments · Fixed by #1487
Closed

[query] Refactor HTTP/gRPC server creation out of main() #1482

yurishkuro opened this issue Apr 22, 2019 · 3 comments · Fixed by #1487
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

https://github.com/jaegertracing/jaeger/pull/1307/files#diff-dd83d41d7df5457b194e8e5ed287cdc3R150

A lot of boilerplate added to main, without tests. We should be able to move it to a sub-package and add proper tests (specifically validating serving http & grpc on the same port).
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Apr 22, 2019
@yurishkuro yurishkuro mentioned this issue Apr 22, 2019
Merged
@stefanvassilev
Copy link
Contributor

Hi @yurishkuro , can i take this? :)

@yurishkuro
Copy link
Member Author

By all means 🤠

stefanvassilev added a commit to stefanvassilev/jaeger that referenced this issue Apr 23, 2019
@stefanvassilev
Refactor grpc server creatin in own package
3f1d360 
Resolves jaegertracing#1482

Signed-off-by: stefan vassilev <[email protected]>
@stefanvassilev stefanvassilev mentioned this issue Apr 23, 2019
Merged
@yurishkuro
Copy link
Member Author

Similar PR for all-in-one #1503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor grpc server creation in own package stefanvassilev/jaeger
2 participants
@yurishkuro @stefanvassilev