Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go-plugin to 1.3 accidentally reverted #2593

Closed
chlunde opened this issue Oct 28, 2020 · 1 comment · Fixed by #2597
Closed

Bump go-plugin to 1.3 accidentally reverted #2593

chlunde opened this issue Oct 28, 2020 · 1 comment · Fixed by #2597
Labels
bug

Comments

@chlunde
Copy link
Contributor

chlunde commented Oct 28, 2020

This change was accidentally reverted (I checked with Pavol). I think the change is as simple as go get github.com/hashicorp/[email protected]; go mod tidy; git add go.sum go.mod; cd cmd/opentelemetry/; go mod tidy; git add go.sum.

One thing I wonder is why the previous change modified go.sum in cmd/opentelemetry/. I see the replace directive there, but I wonder if tidy is the best approach to update go.sum, and if there is any point in doing it at all.

To Reproduce
Steps to reproduce the behavior:

  1. Check version in go.mod

Expected behavior
Find 1.3 since #2261 is merged.
@chlunde chlunde added the bug label Oct 28, 2020
@yurishkuro
Copy link
Member

Put a PR?

chlunde added a commit to chlunde/jaeger that referenced this issue Oct 28, 2020
@chlunde
Bump go-plugin to 1.3
ca1d89f 
    go get github.com/hashicorp/[email protected]; go mod tidy; git add go.sum go.mod
    cd cmd/opentelemetry/; go mod tidy; git add go.sum

Fixes jaegertracing#2593

Signed-off-by: Carl Henrik Lunde <[email protected]>
@chlunde chlunde mentioned this issue Oct 28, 2020
Merged
chlunde added a commit to chlunde/jaeger that referenced this issue Dec 3, 2020
@chlunde
Bump go-plugin to 1.3
8b77563 
    go get github.com/hashicorp/[email protected]; go mod tidy; git add go.sum go.mod
    cd cmd/opentelemetry/; go mod tidy; git add go.sum

Fixes jaegertracing#2593

Signed-off-by: Carl Henrik Lunde <[email protected]>
chlunde added a commit to chlunde/jaeger that referenced this issue Dec 3, 2020
@chlunde
Bump go-plugin to 1.3
a6ae39a 
    go get github.com/hashicorp/[email protected]; go mod tidy; git add go.sum go.mod
    cd cmd/opentelemetry/; go mod tidy; git add go.sum

Fixes jaegertracing#2593

Signed-off-by: Carl Henrik Lunde <[email protected]>
yurishkuro pushed a commit that referenced this issue Dec 3, 2020
@chlunde
Bump go-plugin to 1.3 (#2597)
0cbd8c8 
go get github.com/hashicorp/[email protected]; go mod tidy; git add go.sum go.mod
    cd cmd/opentelemetry/; go mod tidy; git add go.sum

Fixes #2593

Signed-off-by: Carl Henrik Lunde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump go-plugin to 1.3.0 chlunde/jaeger
2 participants
@chlunde @yurishkuro