-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Travis to GitHub actions #2645
Comments
Sure I can pick this work but I am new to GitHub Actions, so it will take some time to get it working. Maybe we can have parallel builds for Travis and GitHub Actions for sometime and once we are satisfied, we can shutdown travis builds. |
We do continue using Travis builds, but for some reason they ran out of credits which are not refreshing. The approach here is to take steps in the Travis matrix one at a time and convert each to GH actions. GH actions are, in the end, just like shell scrips, similar to .travis.yaml. This is a good example: https://github.com/open-telemetry/opentelemetry-specification/blob/master/.github/workflows/checks.yaml |
As part of this issue, we need to migrate following jobs from Travis to Github Actions. Update: the check list is moved to issue description. |
Do you think we should use https://github.com/actions/cache for caching go modules. I feel it will improve the build times. |
We'd need to see the data on how much it speeds up the build. I have a feeling that this is not going to be a significant portion of the overall time, but if it saves 2min our of 12min then it could be worth it. |
One more question: I noticed that |
It is the same script, but the script checks for |
Ah I see, thank you for bringing it to my notice. |
you may want to change that script to take an explicit parameter ( |
Agree. Sure I will update the script. I feel we have too much redundant shell scripts with actions based on env variables which can easily be missed if undefined. In long term, I think we might want to discuss how we want to go ahead. |
It's probably just laziness. Ideally script behavior should be defined by the arguments, not by env vars, at least not by optional vars (required vars that fail the script if not defined are a compromise). Writing arg parsing with getops is not more complicated though, so perhaps worth it. |
This shouldn't be needed. GitHub sets a GOPROXY, which gets the modules from a "local" resource. I did enable caching for the Jaeger Operator but that didn't have a noticeable effect. |
@Ashmita152 to confirm, is the current status correctly reflected in the checkboxes in issue description? I.e. just two more workflows remaining. |
Hi @yurishkuro Sorry for the delay on my side. Yes those are the only two workflows remaining. I will pick them this week. |
We hit the limit of "credits" that Travis provides. Even though the OSS credits are supposed to renew on Nov-23, it's a sign that we need to move away from Travis.
Checklist for migration to GH Actions:
We also need similar changes in the other repositories:
Required before the next Jaeger release:
Can be done independently:
Screenshots from Travis
cc @jaegertracing/jaeger-maintainers @Ashmita152
The text was updated successfully, but these errors were encountered: