-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action for elasticsearch otel integration tests #2671
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2671 +/- ##
==========================================
+ Coverage 95.55% 95.57% +0.02%
==========================================
Files 214 214
Lines 9535 9535
==========================================
+ Hits 9111 9113 +2
+ Misses 346 344 -2
Partials 78 78
Continue to review full report at Codecov.
|
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Hi @yurishkuro Updated the PR with the feedback. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring looks great!
I'm seeing that error again: fatal: No names found, cannot describe anything.
https://github.com/jaegertracing/jaeger/pull/2671/checks?check_run_id=1477915552#step:5:1338
Nice catch. |
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara [email protected]
Which problem is this PR solving?
Adds integration test for Elasticsearch OpenTelemetry.
Part of #2645
Short description of the changes
Also refactors es-integration-test.sh to accept arg either "default" or "otel" otherwise fails.