Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Expose OTLP Ports in all-in-one docker image #4808

Closed
arunvelsriram opened this issue Oct 6, 2023 · 2 comments · Fixed by #4810
Closed

[Feature]: Expose OTLP Ports in all-in-one docker image #4808

arunvelsriram opened this issue Oct 6, 2023 · 2 comments · Fixed by #4810
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@arunvelsriram
Copy link
Contributor

Requirement

In the all-in-one docker image Open Telemetry protocol ports (4317, 4318) need to be exposed. https://github.com/jaegertracing/jaeger/blob/main/cmd/all-in-one/Dockerfile

Problem

We have a testcontainer setup where we rely on the ports marked as exposed by the image. Eg. when running the image with "publish all" flag ie. docker run -P the OTLP ports are not published

Proposal

Let me know if this is okay to expose. Will raise PR post discussion.

Open questions

No response
@yurishkuro
Copy link
Member

Yea they should be. We don't seem to include them in the collector either

@yurishkuro yurishkuro added the help wanted Features that maintainers are willing to accept but do not have cycles to implement label Oct 6, 2023
@arunvelsriram
Copy link
Contributor Author

Okay. Will add it

@arunvelsriram arunvelsriram mentioned this issue Oct 6, 2023
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue Oct 10, 2023
@arunvelsriram
Expose collector ports in docker images (#4810)
45afe75 
## Which problem is this PR solving?
Resolved #4808 

## Description of the changes
- Expose OTLP gRPC and HTTP Collector ports in all-in-one Docker image.
- Expose all collector ports in collector Docker image

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: Arunvel Sriram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose collector ports in all-in-one docker images arunvelsriram/jaeger
2 participants
@yurishkuro @arunvelsriram