Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS client library #576

Closed
yurishkuro opened this issue Dec 2, 2017 · 25 comments
Closed

iOS client library #576

yurishkuro opened this issue Dec 2, 2017 · 25 comments
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

E.g. https://github.com/OutThereLabs/jaeger-client-objc by @pat2man

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement outreachy labels Dec 2, 2017
@swizzlr
Copy link

swizzlr commented Oct 5, 2018

If anyone is actively working on this, let me know. Looking to build a Swift tracer in the near term.

@simonpierreroy
Copy link

@yurishkuro We have worked on it and release a first version of the project. You can take a look and give us feedback. :) https://github.com/wayfair/jaeger-swift

@yurishkuro
Copy link
Member Author

before I do, what's the state of OpenTracing API for iOS? I only see https://github.com/opentracing/opentracing-objc. There's also https://github.com/lightstep/opentracing-swift, which looks like it's being worked on (cc @ryanrhee).

@ryanrhee
Copy link

ryanrhee commented Jan 10, 2019 via email

@yurishkuro
Copy link
Member Author

@ryanrhee are there plans to move it under opentracing org? cc @austinlparker

@austinlparker
Copy link

Lemme check.

@tedsuo
Copy link

tedsuo commented Jan 11, 2019

Let's do it!

@ryanrhee
Copy link

@jmacd mentioned that we'd like to move this under the opentracing org, but I'm not sure what the current status of that is.

@jpkrohling
Copy link
Contributor

What's the status of this one?

@austinlparker
Copy link

We still want to move it, but I don't have permissions to move things into opentracing.

@yurishkuro
Copy link
Member Author

@austinlparker make me admin of that repo and I can move it

@austinlparker
Copy link

done

@yurishkuro
Copy link
Member Author

Which one? I don't see Settings for https://github.com/lightstep/opentracing-swift

@austinlparker
Copy link

Try refreshing? It shows you as admin on the settings page.

@yurishkuro
Copy link
Member Author

I needed to accept the invite. Move is done.

@austinlparker
Copy link

👍

@jmacd
Copy link

jmacd commented Apr 4, 2019 via email

@simonpierreroy
Copy link

simonpierreroy commented Apr 9, 2019

@yurishkuro We just released Jaeger-iOS for Swift-5 https://github.com/wayfair/jaeger-swift. We have been using it for 3 months in our codebase at Wayfair to help improve the performance of our mobile app. (We will soon publish a blog post about it) Let me know if you have any questions.

@ryanrhee
Copy link

ryanrhee commented Apr 9, 2019

@simonpierreroy1 did you write your own opentracing-swift interface? i don't see you using https://github.com/opentracing/opentracing-swift or https://github.com/opentracing/opentracing-objc .

@yurishkuro
Copy link
Member Author

@simonpierreroy1 Great README in your repo! A few questions:

  • Does it implement the API from https://github.com/opentracing/opentracing-swift ?
  • It mentions you submit spans in JSON - which JSON schema are you using?
  • Will you be interested in moving that repo to jaegertracing/jaeger-client-swift?
  • Would you be able to license it with Apache v2 license?

@simonpierreroy
Copy link

@ryanrhee @yurishkuro

  • API: We used our own interface, there was no official one in swift when we started working on that project in October. We created an API that could support Jaeger (and Zepkin in the future) or any type of new implementation of spans. We use “more abstract ideas and types” to represent open-tracing concepts than the ones enforced by the Thrift definition and we map it when serializing to disk or sending spans over a network.

Side note: The public and private interface are 100% documented https://wayfair.github.io/jaeger-swift. If you would like to see the public and private documentation, clone the repo and run jazzy --min-acl private.

  • JSON schema: I can send you the JSON schema, but it is a one-to-one correspondence to https://github.com/jaegertracing/jaeger-idl/blob/master/thrift/jaeger.thrift.

  • Moving the repo and Apache v2 license: Our legal team has requested that our repository stay under the wayfair namespace. If that is ok with you we would still love to be the official version. I can also ask them for the Apache v2 license.

@simonpierreroy
Copy link

Take a look here for more info on our work with Jaeger: https://tech.wayfair.com/2019/05/open-tracing-for-ios-a-performance-tool-for-everyone .

@yurishkuro
Copy link
Member Author

@simonpierreroy1 great article!

@reinpold
Copy link

reinpold commented Sep 6, 2019

Take a look here for more info on our work with Jaeger: https://tech.wayfair.com/2019/05/open-tracing-for-ios-a-performance-tool-for-everyone .

@simonpierreroy1 Thank you for sharing this, it's very useful. Do I understand correctly that your client does not provide the functionality to inject a SpanContext into a carrier using Jaeger's propagation format? I am just wondering how you are propagating the SpanContext to downstream backend services currently?

@yurishkuro
Copy link
Member Author

Jaeger client libraries are officially deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

9 participants