-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS client library #576
Comments
If anyone is actively working on this, let me know. Looking to build a Swift tracer in the near term. |
@yurishkuro We have worked on it and release a first version of the project. You can take a look and give us feedback. :) https://github.com/wayfair/jaeger-swift |
before I do, what's the state of OpenTracing API for iOS? I only see https://github.com/opentracing/opentracing-objc. There's also https://github.com/lightstep/opentracing-swift, which looks like it's being worked on (cc @ryanrhee). |
opentracing-swift is ready for use, no further changes are planned.
…On Fri, Jan 11, 2019 at 7:30 AM Yuri Shkuro ***@***.***> wrote:
before I do, what's the state of OpenTracing API for iOS? I only see
https://github.com/opentracing/opentracing-objc. There's also
https://github.com/lightstep/opentracing-swift, which looks like it's
being worked on (cc @ryanrhee <https://github.com/ryanrhee>).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#576 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOzdINjzGL9bpfIJuO-cBuBBbvtALH0ks5vB77ngaJpZM4QzYzl>
.
|
@ryanrhee are there plans to move it under opentracing org? cc @austinlparker |
Lemme check. |
Let's do it! |
@jmacd mentioned that we'd like to move this under the opentracing org, but I'm not sure what the current status of that is. |
What's the status of this one? |
We still want to move it, but I don't have permissions to move things into opentracing. |
@austinlparker make me admin of that repo and I can move it |
done |
Which one? I don't see Settings for https://github.com/lightstep/opentracing-swift |
Try refreshing? It shows you as admin on the settings page. |
I needed to accept the invite. Move is done. |
👍 |
Cool! Thanks Yuri.
…On Wed, Apr 3, 2019 at 2:59 PM Austin Parker ***@***.***> wrote:
👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#576 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADdiifsfrtV80h1ybV1prjQ7ymGUgFXTks5vdSRVgaJpZM4QzYzl>
.
|
@yurishkuro We just released Jaeger-iOS for Swift-5 https://github.com/wayfair/jaeger-swift. We have been using it for 3 months in our codebase at Wayfair to help improve the performance of our mobile app. (We will soon publish a blog post about it) Let me know if you have any questions. |
@simonpierreroy1 did you write your own opentracing-swift interface? i don't see you using https://github.com/opentracing/opentracing-swift or https://github.com/opentracing/opentracing-objc . |
@simonpierreroy1 Great README in your repo! A few questions:
|
Side note: The public and private interface are 100% documented https://wayfair.github.io/jaeger-swift. If you would like to see the public and private documentation, clone the repo and run
|
Take a look here for more info on our work with Jaeger: https://tech.wayfair.com/2019/05/open-tracing-for-ios-a-performance-tool-for-everyone . |
@simonpierreroy1 great article! |
@simonpierreroy1 Thank you for sharing this, it's very useful. Do I understand correctly that your client does not provide the functionality to inject a SpanContext into a carrier using Jaeger's propagation format? I am just wondering how you are propagating the SpanContext to downstream backend services currently? |
Jaeger client libraries are officially deprecated |
E.g. https://github.com/OutThereLabs/jaeger-client-objc by @pat2man
The text was updated successfully, but these errors were encountered: