Add CI workflow to guard against increases in the binary size #6527
Labels
enhancement
good first issue
Good for beginners
help wanted
Features that maintainers are willing to accept but do not have cycles to implement
Comments
yurishkuro
added
good first issue
|
Working on this . |
4 tasks
4 tasks
yurishkuro
pushed a commit
that referenced
this issue
Jan 17, 2025
## Which problem is this PR solving? - Fix for one issue caused in #6527 ## Description of the changes - cache_output not being set after a cache hit using restore key - Instead check for cache-matched-key != ''" ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: chahatsagarmain <[email protected]>
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this issue
Jan 21, 2025
## Which problem is this PR solving? - Fix for one issue caused in jaegertracing#6527 ## Description of the changes - cache_output not being set after a cache hit using restore key - Instead check for cache-matched-key != ''" ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: chahatsagarmain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to jaegertracing/jaeger-ui#2581, but for the main
jaegerbinary.The text was updated successfully, but these errors were encountered: