Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-idl] Set up code coverage calculation and upload #6572

Closed
yurishkuro opened this issue Jan 20, 2025 · 0 comments
Closed

[jaeger-idl] Set up code coverage calculation and upload #6572

yurishkuro opened this issue Jan 20, 2025 · 0 comments
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jan 20, 2025 •
edited
Loading

Part of #6494

Similar to #6570 but for code coverage.

The coverage is needed for model/v1 package, except for model.pb.go file, similar to how we do this in the main jaeger repo.

Add a badge to README
@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Jan 20, 2025
@dosubot dosubot bot added the enhancement label Jan 20, 2025
@yurishkuro yurishkuro mentioned this issue Jan 20, 2025
Merged
yurishkuro added a commit to jaegertracing/jaeger-idl that referenced this issue Jan 20, 2025
@yurishkuro
Add coverage upload (#119)
18f62b1 
## Which problem is this PR solving?
- Part of jaegertracing/jaeger#6572

## Description of the changes
- Add coverage upload to the workflow

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
@skirtan1 skirtan1 mentioned this issue Jan 23, 2025
Merged
4 tasks
yurishkuro added a commit to jaegertracing/jaeger-idl that referenced this issue Jan 25, 2025
@skirtan1 @yurishkuro
Add coverage calculation and badge (#127)
8a54f16 
## Which problem is this PR solving?
Enhancements for
[#6572](jaegertracing/jaeger#6572)

## Description of the changes
-    Use retry upload action from main branch
-    Delete lines for model.pb.go from coverage
-    add badge to readme

## How was this change tested?
- 

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Shreyas Kirtane <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurishkuro