Badger dependency modifications, alternative version #1720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Burman <[email protected]>
Signed-off-by: Michael Burman <[email protected]>
Signed-off-by: Michael Burman <[email protected]>
Signed-off-by: Michael Burman <[email protected]>
Signed-off-by: Michael Burman <[email protected]>
Signed-off-by: Michael Burman <[email protected]>
Signed-off-by: Michael Burman <[email protected]>
Signed-off-by: Michael Burman <[email protected]> (cherry picked from commit 427f2ad)
burmanm
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
|
@burmanm I think it would be better to first get #1694 sorted, and then once we know the potential direction of jaegertracing/jaeger-ui#399 with respect to the new deep dependency graph mechanism, we can revisit this. I should update that issue to reflect the discussion from the community bi-weekly call. |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to PR #1694. This one allows to use the same query.TraceQueryParameters to create filtered dependency calculations. For example, for jaeger-ui/issue#399