Fix the unbound variable error on all-in-one image build #2675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashmita Bohara [email protected]
Which problem is this PR solving?
When someone creates a PR from fork's master branch, first part of the if condition succeeds and then it looks for DOCKERHUB_LOGIN variable which is only set when we push to master (ie. not for pr) here: https://github.com/jaegertracing/jaeger/blob/master/.github/workflows/ci-all-in-one-build.yml#L38-L41
This is causing unbound variable error. Setting it default to
false
will help in solving the error.This is currently happening for this PR: #2657