-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/prometheus/client_golang from 1.5.1 to 1.10.0 #2888
Bump github.com/prometheus/client_golang from 1.5.1 to 1.10.0 #2888
Conversation
5a7027d
to
100ce34
Compare
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
100ce34
to
d19ed1a
Compare
9e20bdc
to
17a2b7a
Compare
@albertteoh, are you able to handle this update? I think you are going to use this in the metrics reader API, right? |
Yup, leave this one with me @jpkrohling. |
c425ec5
to
c8179db
Compare
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.5.1 to 1.10.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.5.1...v1.10.0) Signed-off-by: dependabot[bot] <[email protected]>
c8179db
to
ee550ac
Compare
@dependabot ignore this minor version these PRs are consuming a lot of CI resources, while we know they will not succeed |
OK, I won't notify you about version 1.10.x again, unless you re-open this PR or update to a 1.10.x release yourself. |
@jpkrohling found some time to look into this... TL;DR if I understand correctly, I don't think we can do much on our end to allow this bump of prometheus/client_golang until gogo proto supports Go protocol buffers APIv2, or if we adopt an OTEL data model as @yurishkuro suggested, which may remove our dependency with gogo proto (I think the motivation for gogo proto is to support custom types like TraceID, and maybe some serde performance benefits, but I could be mistaken). The failing build is caused by bumping github.com/golang/protobuf to v1.4.3, which introduces a deprecation notice:
There's an open issue in gogo/protobuf to address support for Go protocol buffers APIv2 but have not seen any activity for about 4 months. |
Bumps github.com/prometheus/client_golang from 1.5.1 to 1.10.0.
Release notes
Sourced from github.com/prometheus/client_golang's releases.
Changelog
Sourced from github.com/prometheus/client_golang's changelog.
Commits
efe7aa7
Merge pull request #845 from prometheus/beorn7/release853777d
Cut v1.10.04fbf74e
Merge pull request #844 from prometheus/repo_synce92283d
Fix linter ignoresfbc3e40
Update common Prometheus files3cd3985
Merge pull request #843 from prometheus/beorn7/releasee8b72d0
Merge pull request #841 from ntk148v/buildinfo-api4c24ae8
Add buildinfo method6635a8f
Bump minumim required Go version to 1.13a60c63e
Update dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)