Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/prometheus/client_golang from 1.5.1 to 1.10.0 #2888

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 19, 2021

Bumps github.com/prometheus/client_golang from 1.5.1 to 1.10.0.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

1.10.0 / 2021-03-18

  • [CHANGE] Minimum required Go version is now 1.13.
  • [CHANGE] API client: Add matchers to LabelNames and LabesValues. #828
  • [FEATURE] API client: Add buildinfo call. #841
  • [BUGFIX] Fix build on riscv64. #833

1.9.0 / 2020-12-17

  • [FEATURE] NewPidFileFn helper to create process collectors for processes whose PID is read from a file. #804
  • [BUGFIX] promhttp: Prevent endless loop in InstrumentHandler... middlewares with invalid metric or label names. #823

1.8.0 / 2020-10-15

  • [CHANGE] API client: Use time.Time rather than string for timestamps in RuntimeinfoResult. #777
  • [FEATURE] Export MetricVec to facilitate implementation of vectors of custom Metric types. #803
  • [FEATURE API client: Support /status/tsdb endpoint. #773
  • [ENHANCEMENT] API client: Enable GET fallback on status code 501. #802
  • [ENHANCEMENT] Remove Metric references after reslicing to free up more memory. #784

1.7.1 / 2020-06-23

  • [BUGFIX] API client: Actually propagate start/end parameters of LabelNames and LabelValues. #771

1.7.0 / 2020-06-17

  • [CHANGE] API client: Add start/end parameters to LabelNames and LabelValues. #767
  • [FEATURE] testutil: Add GatherAndCount and enable filtering in CollectAndCount #753
  • [FEATURE] API client: Add support for status and runtimeinfo endpoints. #755
  • [ENHANCEMENT] Wrapping nil with a WrapRegistererWith... function creates a no-op Registerer. #764
  • [ENHANCEMENT] promlint: Allow Kelvin as a base unit for cases like color temperature. #761
  • [BUGFIX] push: Properly handle empty job and label values. #752

1.6.0 / 2020-04-28

  • [FEATURE] testutil: Add lint checks for metrics, including a sub-package promlint to expose the linter engine for external usage. #739 #743
  • [ENHANCEMENT] API client: Improve error messages. #731
  • [BUGFIX] process collector: Fix process_resident_memory_bytes on 32bit MS Windows. #734
Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.10.0 / 2021-03-18

  • [CHANGE] Minimum required Go version is now 1.13.
  • [CHANGE] API client: Add matchers to LabelNames and LabesValues. #828
  • [FEATURE] API client: Add buildinfo call. #841
  • [BUGFIX] Fix build on riscv64. #833

1.9.0 / 2020-12-17

  • [FEATURE] NewPidFileFn helper to create process collectors for processes whose PID is read from a file. #804
  • [BUGFIX] promhttp: Prevent endless loop in InstrumentHandler... middlewares with invalid metric or label names. #823

1.8.0 / 2020-10-15

  • [CHANGE] API client: Use time.Time rather than string for timestamps in RuntimeinfoResult. #777
  • [FEATURE] Export MetricVec to facilitate implementation of vectors of custom Metric types. #803
  • [FEATURE API client: Support /status/tsdb endpoint. #773
  • [ENHANCEMENT] API client: Enable GET fallback on status code 501. #802
  • [ENHANCEMENT] Remove Metric references after reslicing to free up more memory. #784

1.7.1 / 2020-06-23

  • [BUGFIX] API client: Actually propagate start/end parameters of LabelNames and LabelValues. #771

1.7.0 / 2020-06-17

  • [CHANGE] API client: Add start/end parameters to LabelNames and LabelValues. #767
  • [FEATURE] testutil: Add GatherAndCount and enable filtering in CollectAndCount #753
  • [FEATURE] API client: Add support for status and runtimeinfo endpoints. #755
  • [ENHANCEMENT] Wrapping nil with a WrapRegistererWith... function creates a no-op Registerer. #764
  • [ENHANCEMENT] promlint: Allow Kelvin as a base unit for cases like color temperature. #761
  • [BUGFIX] push: Properly handle empty job and label values. #752

1.6.0 / 2020-04-28

  • [FEATURE] testutil: Add lint checks for metrics, including a sub-package promlint to expose the linter engine for external usage. #739 #743
  • [ENHANCEMENT] API client: Improve error messages. #731
  • [BUGFIX] process collector: Fix process_resident_memory_bytes on 32bit MS Windows. #734
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 19, 2021 07:04
@dependabot dependabot bot requested a review from joe-elliott March 19, 2021 07:04
@dependabot dependabot bot requested a review from yurishkuro March 19, 2021 07:04
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.10.0 branch from 5a7027d to 100ce34 Compare March 26, 2021 17:56
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 30, 2021

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.10.0 branch from 100ce34 to d19ed1a Compare May 4, 2021 23:46
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.10.0 branch 4 times, most recently from 9e20bdc to 17a2b7a Compare May 12, 2021 14:18
@jpkrohling
Copy link
Contributor

@albertteoh, are you able to handle this update? I think you are going to use this in the metrics reader API, right?

@albertteoh
Copy link
Contributor

Yup, leave this one with me @jpkrohling.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.10.0 branch 7 times, most recently from c425ec5 to c8179db Compare May 18, 2021 20:13
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.10.0 branch from c8179db to ee550ac Compare May 18, 2021 21:09
@yurishkuro
Copy link
Member

@dependabot ignore this minor version

these PRs are consuming a lot of CI resources, while we know they will not succeed

@dependabot dependabot bot closed this May 18, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 18, 2021

OK, I won't notify you about version 1.10.x again, unless you re-open this PR or update to a 1.10.x release yourself.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.10.0 branch May 18, 2021 21:28
@albertteoh
Copy link
Contributor

@jpkrohling found some time to look into this... TL;DR if I understand correctly, I don't think we can do much on our end to allow this bump of prometheus/client_golang until gogo proto supports Go protocol buffers APIv2, or if we adopt an OTEL data model as @yurishkuro suggested, which may remove our dependency with gogo proto (I think the motivation for gogo proto is to support custom types like TraceID, and maybe some serde performance benefits, but I could be mistaken).

The failing build is caused by bumping github.com/golang/protobuf to v1.4.3, which introduces a deprecation notice:

package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead.

google.golang.org/protobuf/proto is the new module name for Go protocol buffers APIv2, which introduces a breaking change, which we'll see in our zipkin http_handler, for instance, where proto.Unmarshal is expecting a Message that implements the ProtoMessage interface, leading to compilation errors because gogo proto does not currently support Go protocol buffers APIv2.

There's an open issue in gogo/protobuf to address support for Go protocol buffers APIv2 but have not seen any activity for about 4 months.

@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants