Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node to 16 #3957

Merged
merged 4 commits into from
Oct 9, 2022
Merged

Update node to 16 #3957

merged 4 commits into from
Oct 9, 2022

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 8, 2022

Signed-off-by: Matthieu MOREL [email protected]

Which problem is this PR solving?

Short description of the changes

  • Update node to 16

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 97.14% // Head: 97.13% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (6c1cf6e) compared to base (878992a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3957      +/-   ##
==========================================
- Coverage   97.14%   97.13%   -0.01%     
==========================================
  Files         295      295              
  Lines       17389    17389              
==========================================
- Hits        16892    16891       -1     
  Misses        400      400              
- Partials       97       98       +1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 96.38% <0.00%> (-1.81%) ⬇️
pkg/config/tlscfg/cert_watcher.go 94.68% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmorel-35 mmorel-35 marked this pull request as ready for review October 9, 2022 07:51
@mmorel-35 mmorel-35 requested a review from a team as a code owner October 9, 2022 07:51
@mmorel-35 mmorel-35 requested a review from pavolloffay October 9, 2022 07:51
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
@yurishkuro yurishkuro merged commit 2e8c6b2 into jaegertracing:main Oct 9, 2022
@mmorel-35 mmorel-35 deleted the patch-2 branch October 9, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants