[refactor] Move model<->otlp translation from jptrace to v1adapter
#6414
+37
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Dec 25, 2024
storage_v2/v1adapter/translator.go
Outdated
| @@ -24,7 +25,7 @@ func ProtoFromTraces(traces ptrace.Traces) []*model.Batch { | |||
| // to OpenTelemetry traces (ptrace.Traces). | |||
| func ProtoToTraces(batches []*model.Batch) ptrace.Traces { | |||
There was a problem hiding this comment.
can we change the name of the function? E.g. ModelBatchesToTraces. Because in some cases it's also useful to have model.Trace as input/output, not just model.Batch, and the naming does not allow that.
There was a problem hiding this comment.
or even better V1BatchesToTraces
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6414 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 368 368
Lines 20979 20979
=======================================
Hits 20193 20193
Misses 601 601
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Dec 25, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
jaegertracing#6414) ## Description of the changes - Move model<->otlp translation from `jptrace` to `v1adapter` to keep `jptrace` specific to helper around the `ptrace` domain objects. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
jptracetov1adapterto keepjptracespecific to helper around theptracedomain objects.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test