Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not test with Kafka 2.x #6427

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 27, 2024

Which problem is this PR solving?

Description of the changes

  • Remove Kafka 2.x from the test matrix
  • Remove the corresponding docker-compose file

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (8e8f72e) to head (f9f7e33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6427   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         368      368           
  Lines       21008    21008           
=======================================
  Hits        20225    20225           
  Misses        599      599           
  Partials      184      184           
Flag Coverage Δ
badger_v1 10.55% <ø> (ø)
badger_v2 3.03% <ø> (ø)
cassandra-4.x-v1-manual 16.43% <ø> (ø)
cassandra-4.x-v2-auto 2.96% <ø> (ø)
cassandra-4.x-v2-manual 2.96% <ø> (ø)
cassandra-5.x-v1-manual 16.43% <ø> (ø)
cassandra-5.x-v2-auto 2.96% <ø> (ø)
cassandra-5.x-v2-manual 2.96% <ø> (ø)
elasticsearch-6.x-v1 20.16% <ø> (ø)
elasticsearch-7.x-v1 20.24% <ø> (ø)
elasticsearch-8.x-v1 20.40% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 3.06% <ø> (-0.14%) ⬇️
grpc_v1 12.21% <ø> (ø)
grpc_v2 9.31% <ø> (ø)
kafka-2.x-v1 ?
kafka-2.x-v2 ?
kafka-3.x-v1 10.39% <ø> (ø)
kafka-3.x-v2 3.06% <ø> (ø)
memory_v2 3.05% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 20.29% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 20.29% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 3.05% <ø> (ø)
tailsampling-processor 0.56% <ø> (ø)
unittests 95.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro marked this pull request as ready for review December 27, 2024 17:16
@yurishkuro yurishkuro requested a review from a team as a code owner December 27, 2024 17:16
@yurishkuro yurishkuro requested a review from jkowall December 27, 2024 17:16
@dosubot dosubot bot added docker Pull requests that update Docker code storage/kafka labels Dec 27, 2024
@yurishkuro yurishkuro merged commit f042ff0 into jaegertracing:main Dec 27, 2024
57 checks passed
@yurishkuro yurishkuro deleted the remove-kafka2 branch December 27, 2024 17:21
Manik2708 pushed a commit to Manik2708/jaeger that referenced this pull request Jan 5, 2025
## Which problem is this PR solving?
- Resolves jaegertracing#3068
- According to https://endoflife.date/apache-kafka the support for Kafka
2.x ended 2yrs ago. There is no reason to waste CI resources testing
against it.
- Our documentation only mentions 3.x
https://www.jaegertracing.io/docs/2.1/kafka/

## Description of the changes
- Remove Kafka 2.x from the test matrix
- Remove the corresponding docker-compose file

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing docker Pull requests that update Docker code storage/kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document and update integration test with the versions of Kafka Jaeger supports
2 participants