[storage] Change storage extension to hold v2 factories #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
commented
Feb 9, 2025
4 tasks
mahadzaryab1
added a commit
that referenced
this pull request
Feb 9, 2025
## Which problem is this PR solving? - Towards #6697 ## Description of the changes - This is a prequel to #6699. This PR refactors the `TraceReader` to conditionally propagate the implementations of `storage.Purger` and `storage.SamplingStoreFactory`. Without this change, the implementation of the aforementioned interfaces get lost when we wrap a v1 `SpanReader`. ## How was this change tested? - Added unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
mahadzaryab1
added a commit
that referenced
this pull request
Feb 12, 2025
…6710) ## Which problem is this PR solving? - Towards #6697 ## Description of the changes - This is a prequel to #6699. This PR refactors `v1adapter.Factory` to conditionally propagate the implementations of `storage.Purger` and `storage.SamplingStoreFactory`. Without this change, the implementation of the aforementioned interfaces get lost when we wrap a v1 `storage.Factory` into the adapter.. ## How was this change tested? - Added unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6699 +/- ##
==========================================
+ Coverage 96.00% 96.02% +0.02%
==========================================
Files 363 363
Lines 20591 20595 +4
==========================================
+ Hits 19768 19777 +9
+ Misses 629 624 -5
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Feb 12, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
jaegerstorageextension to hold the newtracestore.Factoryinstead of the v1storage.Factory. Currently, all storage implementations are wrapped into the v1adapter. However, this PR unblocks the path for a native v2 storage implementation.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test