Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pkg/cache to internal #6720

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

won-js
Copy link
Contributor

@won-js won-js commented Feb 12, 2025

Which problem is this PR solving?

Description of the changes

move pkg/cache to internal

How was this change tested?

Checklist

@won-js won-js requested a review from a team as a code owner February 12, 2025 12:19
@won-js won-js requested a review from mahadzaryab1 February 12, 2025 12:19
@dosubot dosubot bot added the area/storage label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (348a687) to head (c46d98a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6720      +/-   ##
==========================================
- Coverage   96.01%   96.00%   -0.02%     
==========================================
  Files         363      363              
  Lines       20595    20595              
==========================================
- Hits        19775    19772       -3     
- Misses        626      628       +2     
- Partials      194      195       +1     
Flag Coverage Δ
badger_v1 9.80% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-4.x-v1-manual 14.76% <ø> (ø)
cassandra-4.x-v2-auto 1.80% <ø> (ø)
cassandra-4.x-v2-manual 1.80% <ø> (ø)
cassandra-5.x-v1-manual 14.76% <ø> (ø)
cassandra-5.x-v2-auto 1.80% <ø> (ø)
cassandra-5.x-v2-manual 1.80% <ø> (ø)
elasticsearch-6.x-v1 19.08% <ø> (ø)
elasticsearch-7.x-v1 19.16% <ø> (ø)
elasticsearch-8.x-v1 19.33% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 10.77% <ø> (ø)
grpc_v2 7.78% <ø> (ø)
kafka-3.x-v1 10.09% <ø> (ø)
kafka-3.x-v2 1.81% <ø> (ø)
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 19.21% <ø> (ø)
opensearch-2.x-v1 19.21% <ø> (ø)
opensearch-2.x-v2 1.81% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

please make sure commits are signed off

@won-js won-js force-pushed the move-pkg-cache-to-internal branch from baadad7 to c46d98a Compare February 12, 2025 13:51
@won-js
Copy link
Contributor Author

won-js commented Feb 12, 2025

Apologies for missing the Signed-off-by line.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yurishkuro yurishkuro enabled auto-merge (squash) February 12, 2025 15:29
@yurishkuro yurishkuro disabled auto-merge February 12, 2025 15:30
@yurishkuro yurishkuro merged commit a922f2d into jaegertracing:main Feb 12, 2025
55 of 56 checks passed
@won-js won-js deleted the move-pkg-cache-to-internal branch February 16, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants